Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 )
Change subject: KUDU-2245 Graceful leadership transfer ...................................................................... Patch Set 15: (5 comments) The "signature" of WARN_NOT_OK is WARN_NOT_OK(Status s, string prefix) so I switched around a little how the error messages are constructed but it's the same idea of pushing the error handling up one level. http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/peer_manager.cc File src/kudu/consensus/peer_manager.cc: http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/peer_manager.cc@110 PS15, Line 110: void PeerManager::StartElection(const std::string& uuid) { > Seems like this function should return a Status so we can decide how to han Done http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/peer_manager.cc@119 PS15, Line 119: return; > how about: Done http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/peer_manager.cc@121 PS15, Line 121: Status s = peer->StartElection(); > how about; Done http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/raft_consensus.cc@991 PS15, Line 991: peer_manager_->StartElection(peer_uuid); > can we do the warning here? Done http://gerrit.cloudera.org:8080/#/c/11251/15/src/kudu/consensus/raft_consensus.cc@991 PS15, Line 991: peer_manager_->StartElection(peer_uuid); > i mean something like WARN_NOT_OK here (thumbsup) -- To view, visit http://gerrit.cloudera.org:8080/11251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic97343af9eb349556424c999799ed5e2941f0083 Gerrit-Change-Number: 11251 Gerrit-PatchSet: 15 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 16 Oct 2018 18:41:53 +0000 Gerrit-HasComments: Yes
