Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11684 )
Change subject: [tools] Add checking for row existence to the locate_row tool ...................................................................... Patch Set 4: (2 comments) New changelist for the one change: http://gerrit.cloudera.org:8080/11715 http://gerrit.cloudera.org:8080/#/c/11684/4/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11684/4/src/kudu/tools/kudu-admin-test.cc@1795 PS4, Line 1795: // Test the case when the row exists. Since the scan is done by a subprocess : // using a different client instance, it's possible the scan will not : // immediately retrieve the row even though the write has already succeeded, : // so we ASSERT_EVENTUALLY. > Nit: could add that this is what timestamp propagation is intended for, but Done http://gerrit.cloudera.org:8080/#/c/11684/4/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/11684/4/src/kudu/tools/tool_action_table.cc@300 PS4, Line 300: RETURN_NOT_OK(ScanToStrings(scanner.get(), &row_str)); > This from the kudu_client_test_util target, and I'm surprised it's linked i Maybe it's just a naming problem? What if it were called client_util.{h,cc} and the library was kudu_client_util? I also noticed the perf tool implements its own version of CountTableRows, so we could deduplicate code there too. -- To view, visit http://gerrit.cloudera.org:8080/11684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760d3fbb2e30a3ffba7143d3b51da6f3fd62b034 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 17 Oct 2018 22:16:46 +0000 Gerrit-HasComments: Yes
