Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11684 )
Change subject: [tools] Add checking for row existence to the locate_row tool ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11684/4/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/11684/4/src/kudu/tools/tool_action_table.cc@300 PS4, Line 300: RETURN_NOT_OK(ScanToStrings(scanner.get(), &row_str)); > Maybe it's just a naming problem? What if it were called client_util.{h,cc} Sure, but there is some test-specific stuff in there. Like ScanTabletoStrings(), which has asserts in it. -- To view, visit http://gerrit.cloudera.org:8080/11684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I760d3fbb2e30a3ffba7143d3b51da6f3fd62b034 Gerrit-Change-Number: 11684 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 17 Oct 2018 22:35:06 +0000 Gerrit-HasComments: Yes
