Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11251 )
Change subject: KUDU-2245 Graceful leadership transfer ...................................................................... Patch Set 17: (4 comments) http://gerrit.cloudera.org:8080/#/c/11251/17/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: http://gerrit.cloudera.org:8080/#/c/11251/17/src/kudu/consensus/consensus_queue.h@468 PS17, Line 468: // Determine if 'peer' is fully caught up to the leader. If it is, notify : // observers. : void DetermineIfCaughtUp(const TrackedPeer& peer, const ConsensusStatusPB& status); > Let's rename this method to something like TransferLeadershipIfNeeded() and Done http://gerrit.cloudera.org:8080/#/c/11251/17/src/kudu/integration-tests/raft_consensus-itest.cc File src/kudu/integration-tests/raft_consensus-itest.cc: http://gerrit.cloudera.org:8080/#/c/11251/17/src/kudu/integration-tests/raft_consensus-itest.cc@3024 PS17, Line 3024: TEST_F(RaftConsensusITest, TestLeaderTransferWhenFollowerFallsBehindLeaderGC) { > please add a test comment with something like: // Designating graceful lead Done http://gerrit.cloudera.org:8080/#/c/11251/17/src/kudu/tools/kudu-admin-test.cc File src/kudu/tools/kudu-admin-test.cc: http://gerrit.cloudera.org:8080/#/c/11251/17/src/kudu/tools/kudu-admin-test.cc@1571 PS17, Line 1571: "leader_step_down", > didn't see a reply posted yet, not sure if you saw this comment (facepalm) http://gerrit.cloudera.org:8080/#/c/11251/17/src/kudu/tools/kudu-admin-test.cc@1571 PS17, Line 1571: "leader_step_down", > This seems to be the only test we have for non-designated graceful leader s Graceful stepdown does not guarantee leadership transfer any more than abrupt stepdown does- if no peer catches up during the transfer period, the leader will resume its normal operation. See L1297 for a test of graceful transfer without designating a successor. In that case, failure detection is disabled and there are no other writes, so leader transfer should succeed almost surely within multi-second timeouts even with TSAN / stress thread slowdowns. -- To view, visit http://gerrit.cloudera.org:8080/11251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic97343af9eb349556424c999799ed5e2941f0083 Gerrit-Change-Number: 11251 Gerrit-PatchSet: 17 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Fengling Wang <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 18 Oct 2018 00:17:26 +0000 Gerrit-HasComments: Yes
