Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11710 )
Change subject: benchmarks: work around missing node_density-itest timing measurements ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11710/2/src/kudu/scripts/benchmarks.sh File src/kudu/scripts/benchmarks.sh: http://gerrit.cloudera.org:8080/#/c/11710/2/src/kudu/scripts/benchmarks.sh@433 PS2, Line 433: For some inexplicable reason nit: maybe, add TODO for easier tracking this issue in the future, like # TODO: remove the workaround once it's clear why sometimes the measurements were absent in the log file. http://gerrit.cloudera.org:8080/#/c/11710/2/src/kudu/scripts/benchmarks.sh@434 PS2, Line 434: missing from the log file Just for better understanding: was that about missing measurement in the logs or that was something wrong with extraction of that information from the logs? -- To view, visit http://gerrit.cloudera.org:8080/11710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa4d0b01596fc6f022bad19bcb79afdfbb5dcaef Gerrit-Change-Number: 11710 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 18 Oct 2018 01:09:57 +0000 Gerrit-HasComments: Yes
