Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11710 )
Change subject: benchmarks: work around missing node_density-itest timing measurements ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11710/2/src/kudu/scripts/benchmarks.sh File src/kudu/scripts/benchmarks.sh: http://gerrit.cloudera.org:8080/#/c/11710/2/src/kudu/scripts/benchmarks.sh@433 PS2, Line 433: For some inexplicable reason > nit: maybe, add TODO for easier tracking this issue in the future, like Eh, we've spent so much time/effort (relative to the gain) on this that I can't imagine we'll spend anymore. http://gerrit.cloudera.org:8080/#/c/11710/2/src/kudu/scripts/benchmarks.sh@434 PS2, Line 434: missing from the log file > Just for better understanding: was that about missing measurement in the lo The actual LOG_TIMING() output was missing from the log file. Todd did some work to track down why, but could never figure it out. -- To view, visit http://gerrit.cloudera.org:8080/11710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaa4d0b01596fc6f022bad19bcb79afdfbb5dcaef Gerrit-Change-Number: 11710 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 19:57:30 +0000 Gerrit-HasComments: Yes
