Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11716 )
Change subject: catalog_manager: adjust maximum tablet count at table creation time ...................................................................... catalog_manager: adjust maximum tablet count at table creation time The maximum tablet check introduced in commit 64983c454 was incomplete in that it only considered the number of _tablets_ rather than the number of _replicas_, even though replica creation itself places load on a tserver during table creation. This patch clarifies the intended behavior and incorporates the replication factor of the table into the check. Note: users who override --max_create_tablets_per_ts are in for a rude surprise as the maximum size of their tables will be effectively cut in three. Given that the parameter isn't tagged as "stable" though, I think communicating this change in behavior via release note is sufficient. Change-Id: I00d91baddb1591476a7be27cba043e6354558208 Reviewed-on: http://gerrit.cloudera.org:8080/11716 Reviewed-by: Dan Burkert <[email protected]> Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M docs/known_issues.adoc M src/kudu/client/client-test.cc M src/kudu/integration-tests/raft_consensus_stress-itest.cc M src/kudu/master/catalog_manager.cc 4 files changed, 40 insertions(+), 26 deletions(-) Approvals: Dan Burkert: Looks good to me, but someone else must approve Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/11716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I00d91baddb1591476a7be27cba043e6354558208 Gerrit-Change-Number: 11716 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]>
