Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/11716 )
Change subject: catalog_manager: adjust maximum tablet count at table creation time ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11716/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/11716/3/src/kudu/master/catalog_manager.cc@196 PS3, Line 196: replicated > I think this is a bit too subtle. I suggest instead changing it to 'The nu Agreed. http://gerrit.cloudera.org:8080/#/c/11716/3/src/kudu/master/catalog_manager.cc@1506 PS3, Line 1506: tablets (post-replication) "tablet replicas" to be consistent with the docs on the config. -- To view, visit http://gerrit.cloudera.org:8080/11716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00d91baddb1591476a7be27cba043e6354558208 Gerrit-Change-Number: 11716 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 19 Oct 2018 23:25:56 +0000 Gerrit-HasComments: Yes
