Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11821 to look at the new patch set (#2). Change subject: Stop using client-test-util in tools ...................................................................... Stop using client-test-util in tools The `kudu hms` and `kudu table` tools both had actions which used functions from the client-test-util library. This meant test code was being linked into production code, which is bad. The functions used by the tool code were ScanToStrings: Used in one place in tool code, so I just wrote the KuduScanner iteration loop explicitly instead. KuduSchemaFromSchema and SchemaFromKuduSchema: Replaced (both in tests and tool code) by two static functions KuduSchema::FromSchema and KuduSchema::ToSchema. These functions are not exported. Change-Id: Ide54a0adce191a572960de678f0f7ee69eec8c2d --- M src/kudu/client/client-test-util.cc M src/kudu/client/client-test-util.h M src/kudu/client/client-unittest.cc M src/kudu/client/client.cc M src/kudu/client/scan_configuration.cc M src/kudu/client/schema.cc M src/kudu/client/schema.h M src/kudu/integration-tests/authn_token_expire-itest.cc M src/kudu/integration-tests/catalog_manager_tsk-itest.cc M src/kudu/integration-tests/client-negotiation-failover-itest.cc M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/fuzz-itest.cc M src/kudu/integration-tests/security-faults-itest.cc M src/kudu/integration-tests/security-itest.cc M src/kudu/integration-tests/security-unknown-tsk-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/test_workload.cc M src/kudu/integration-tests/ts_itest-base.cc M src/kudu/tools/CMakeLists.txt M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tools/rebalancer_tool-test.cc M src/kudu/tools/tool_action_hms.cc M src/kudu/tools/tool_action_table.cc 25 files changed, 61 insertions(+), 64 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/11821/2 -- To view, visit http://gerrit.cloudera.org:8080/11821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ide54a0adce191a572960de678f0f7ee69eec8c2d Gerrit-Change-Number: 11821 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)