Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11821 )
Change subject: Stop using client-test-util in tools ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/11821/2/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/11821/2/src/kudu/client/schema.h@577 PS2, Line 577: // Convert a KuduSchema to or from an internal Schema. > This probably merits a more Doxygen-friendly syntax. See client.h for some Done http://gerrit.cloudera.org:8080/#/c/11821/2/src/kudu/client/schema.h@577 PS2, Line 577: // Convert a KuduSchema to or from an internal Schema. > +1 Done http://gerrit.cloudera.org:8080/#/c/11821/2/src/kudu/client/schema.h@578 PS2, Line 578: static KuduSchema FromSchema(const Schema& schema) KUDU_NO_EXPORT; : static Schema ToSchema(const KuduSchema& kudu_schema) KUDU_NO_EXPORT; > Could you add doxygen-style documentation for those functions and put that Done -- To view, visit http://gerrit.cloudera.org:8080/11821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide54a0adce191a572960de678f0f7ee69eec8c2d Gerrit-Change-Number: 11821 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 30 Oct 2018 16:16:59 +0000 Gerrit-HasComments: Yes
