Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11750 )
Change subject: KUDU-2542: add initial authorization token impl ...................................................................... Patch Set 3: (6 comments) Overall looks good, just a few questions and nits. http://gerrit.cloudera.org:8080/#/c/11750/3/src/kudu/security/token-test.cc File src/kudu/security/token-test.cc: http://gerrit.cloudera.org:8080/#/c/11750/3/src/kudu/security/token-test.cc@95 PS3, Line 95: signed_token nit: wrap into std::move() ? http://gerrit.cloudera.org:8080/#/c/11750/3/src/kudu/security/token-test.cc@98 PS3, Line 98: last_signed nit: wrap into std::move() ? http://gerrit.cloudera.org:8080/#/c/11750/3/src/kudu/security/token-test.cc@760 PS3, Line 760: const tiny nit: constexpr? (feel free to ignore, though) http://gerrit.cloudera.org:8080/#/c/11750/3/src/kudu/security/token-test.cc@790 PS3, Line 790: n z? http://gerrit.cloudera.org:8080/#/c/11750/3/src/kudu/security/token-test.cc@855 PS3, Line 855: ASSERT_OK nit: I remember some issues were reported with ASSERT_OK() in threads (i.e. when an assertion fires). I'm curious whether it works as intended in here. http://gerrit.cloudera.org:8080/#/c/11750/3/src/kudu/security/token-test.cc@861 PS3, Line 861: verify_expired What does it turn to be if an assertion fires in verify_expired()? Is it necessary to wrap this into something like NO_FATALS() ? -- To view, visit http://gerrit.cloudera.org:8080/11750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f Gerrit-Change-Number: 11750 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 30 Oct 2018 04:31:34 +0000 Gerrit-HasComments: Yes
