Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11750 )
Change subject: KUDU-2542: add initial authorization token impl ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token-test.cc File src/kudu/security/token-test.cc: http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token-test.cc@73 PS2, Line 73: Status SignUntilRotatePast(TokenSigner* signer, TokenGenerator generate_token, > warning: the const qualified parameter 'token_type' is copied for each invo Done http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token.proto File src/kudu/security/token.proto: http://gerrit.cloudera.org:8080/#/c/11750/2/src/kudu/security/token.proto@38 PS2, Line 38: optional bool scan_privilege = 2; > Start at 2 Done -- To view, visit http://gerrit.cloudera.org:8080/11750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id28747ec38675abdf50dce1e7c176d29213e370f Gerrit-Change-Number: 11750 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 25 Oct 2018 05:58:38 +0000 Gerrit-HasComments: Yes
