Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11836 )
Change subject: revert change to exactly_once_writes-itest ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11836/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11836/1//COMMIT_MSG@9 PS1, Line 9: 5894af6ff12291ffab2d3304b34f77fe6d112771 Wrong hash; I think you meant bc817a44867c586bf4e0539aa564b282c666a49d here. http://gerrit.cloudera.org:8080/#/c/11836/1//COMMIT_MSG@14 PS1, Line 14: So instead, I'm reverting the test change that led : to its leakiness. But the changes you're reverting are to the wrong test; the leak was reported in CrashyNodes, not ChurnyElections (at least, according to the log you attached in KUDU-2517). https://gerrit.cloudera.org/c/7052/ seems related. Maybe ask Todd what he remembers about that particular issue? BTW, were you able to repro the leak with LSAN_OPTIONS=fast_unwind_on_malloc=0? If you can repro the failure locally when running a full ctest suite, maybe leave your machine running overnight with the test suite running in a loop? -- To view, visit http://gerrit.cloudera.org:8080/11836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4091d3905d871acb48ec4d88c7b81ee48bf0eed Gerrit-Change-Number: 11836 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 31 Oct 2018 04:34:54 +0000 Gerrit-HasComments: Yes
