Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11836 )
Change subject: revert change to exactly_once_writes-itest ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11836/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11836/1//COMMIT_MSG@9 PS1, Line 9: bc817a44867c586bf4e0539aa564b282c666a49d > Wrong hash; I think you meant bc817a44867c586bf4e0539aa564b282c666a49d here Done http://gerrit.cloudera.org:8080/#/c/11836/1//COMMIT_MSG@14 PS1, Line 14: So instead, I'm reverting the test change that led : to its leakiness. > But the changes you're reverting are to the wrong test; the leak was report You're right about the Jira; I've commented about it and added a log. Since filing the original ticket, I haven't seen that same flakiness. Yeah, I wonder if the spirit of that change implies that we should be ignoring these "transient" leaks, if they don't persistently show up in that final leak check. I'll bug Todd about it. I tried with that in ASAN_OPTIONS, I can try with LSAN_OPTIONS. It's notable though that given that the test aims to churn elections, slowing things down like this makes it pretty unlikely that the test will pass. -- To view, visit http://gerrit.cloudera.org:8080/11836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If4091d3905d871acb48ec4d88c7b81ee48bf0eed Gerrit-Change-Number: 11836 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 31 Oct 2018 05:00:15 +0000 Gerrit-HasComments: Yes
