Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11843 )
Change subject: [util] Add ParseStringsWithScheme in net_util ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/11843/1/src/kudu/util/net/net_util.h File src/kudu/util/net/net_util.h: http://gerrit.cloudera.org:8080/#/c/11843/1/src/kudu/util/net/net_util.h@46 PS1, Line 46: be nit: drop http://gerrit.cloudera.org:8080/#/c/11843/1/src/kudu/util/net/net_util.h@46 PS1, Line 46: . nit: a comma (,) instead of a period (.)? http://gerrit.cloudera.org:8080/#/c/11843/1/src/kudu/util/net/net_util.h@49 PS1, Line 49: host Maybe, add a note that <host> component cannot be in IPv6 address notation. http://gerrit.cloudera.org:8080/#/c/11843/1/src/kudu/util/net/net_util.h@76 PS1, Line 76: be nit: drop -- To view, visit http://gerrit.cloudera.org:8080/11843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2447ab80e0b0737c4eb2ba8216769a52b5c07ce0 Gerrit-Change-Number: 11843 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 01 Nov 2018 04:25:23 +0000 Gerrit-HasComments: Yes
