Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11843 )
Change subject: [util] Add ParseStringsWithScheme in net_util ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11843/1/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: http://gerrit.cloudera.org:8080/#/c/11843/1/src/kudu/util/net/net_util.cc@153 PS1, Line 153: > Hmm, I did not see how since StripPrefixString or StripSuffixString are rel Ah, yeah I saw what you mean; since the entirety of the scheme and path aren't known up front, you can't use those functions to find them. -- To view, visit http://gerrit.cloudera.org:8080/11843 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2447ab80e0b0737c4eb2ba8216769a52b5c07ce0 Gerrit-Change-Number: 11843 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 01 Nov 2018 17:13:20 +0000 Gerrit-HasComments: Yes
