Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11815 )
Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11815/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11815/1//COMMIT_MSG@13 PS1, Line 13: : The off-by-one errors are possibly due to very fast : test runs where the writes and backups start : in under 1ms. They could also be due to some : underlying issue that is not well understood. > +1 I am suspicious of fixing a test failure like this with a sleep, and par Done. I added an explanation and +1 ms to the snapshot scan. I also added logging just in case we see this flake in the future. http://gerrit.cloudera.org:8080/#/c/11815/1//COMMIT_MSG@20 PS1, Line 20: > dist-test works with Java now right? Can you run some experiments to demons This failure is very difficult to produce in dist-test. I ran 500 tests before and after changes and couldn't produce it in either. -- To view, visit http://gerrit.cloudera.org:8080/11815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0f1b4a4138cc8c913543a68fad748927cdc439d Gerrit-Change-Number: 11815 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 17:09:54 +0000 Gerrit-HasComments: Yes
