Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11815 )
Change subject: KUDU-2584: Prevent flaky off-by-one errors in backup tests ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11815/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala: http://gerrit.cloudera.org:8080/#/c/11815/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduBackupRDD.scala@138 PS2, Line 138: kuduContext.timestampAccumulator.add(kuduContext.syncClient.getLastPropagatedTimestamp) > This was added because it brings KuduBackupRDD closer to KuduRDD. Given we I think updating timestamp on driver with max of timestamp on executors is important for READ_AT_SNAPSHPT mode as well if the same KuduContext is used. -- To view, visit http://gerrit.cloudera.org:8080/11815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0f1b4a4138cc8c913543a68fad748927cdc439d Gerrit-Change-Number: 11815 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 06 Nov 2018 19:49:55 +0000 Gerrit-HasComments: Yes
