Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11902 )
Change subject: [catalog_manager] cleanup on InitTokenSigner ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11902/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11902/1//COMMIT_MSG@9 PS1, Line 9: logner nit: longer http://gerrit.cloudera.org:8080/#/c/11902/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/11902/1/src/kudu/master/sys_catalog.cc@746 PS1, Line 746: DCHECK(!entry_ids.empty()); : if (entry_ids.empty()) { : return Status::InvalidArgument("empty set of TSK entries to remove"); : } Maybe doc that this is disallowed in the header? Also I'm not sure returning an error is necessary here; I've generally added DCHECK/CHECKs if it's a programmer error, and returned errors if it's a possible input that we should be handling. In this case, I think it'd be a programmer error, right? -- To view, visit http://gerrit.cloudera.org:8080/11902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68eb1972c0ab330c7739e6901ebe36e4190144cc Gerrit-Change-Number: 11902 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Nov 2018 18:57:28 +0000 Gerrit-HasComments: Yes
