Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11902 )
Change subject: [catalog_manager] cleanup on InitTokenSigner ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11902/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11902/1//COMMIT_MSG@9 PS1, Line 9: logner > nit: longer Done http://gerrit.cloudera.org:8080/#/c/11902/1/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/11902/1/src/kudu/master/sys_catalog.cc@746 PS1, Line 746: DCHECK(!entry_ids.empty()); : if (entry_ids.empty()) { : return Status::InvalidArgument("empty set of TSK entries to remove"); : } > Maybe doc that this is disallowed in the header? Also I'm not sure returnin Yes, we can classify it as a grave programming error and crash even in non-debug mode. Done. -- To view, visit http://gerrit.cloudera.org:8080/11902 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68eb1972c0ab330c7739e6901ebe36e4190144cc Gerrit-Change-Number: 11902 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 07 Nov 2018 19:40:49 +0000 Gerrit-HasComments: Yes
