Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11886 )
Change subject: run-test: don't report leaks that don't fail test ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11886/4/src/kudu/server/generic_service.cc File src/kudu/server/generic_service.cc: http://gerrit.cloudera.org:8080/#/c/11886/4/src/kudu/server/generic_service.cc@183 PS4, Line 183: if (!has_leaks) { > May want to make this bigger so it stands out from the report. And maybe WA Done -- To view, visit http://gerrit.cloudera.org:8080/11886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f199795c48bd9b6106110aae132ec165eb0f647 Gerrit-Change-Number: 11886 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 08 Nov 2018 00:48:19 +0000 Gerrit-HasComments: Yes