Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11886 )
Change subject: run-test: don't report leaks that don't fail test ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/11886/3/src/kudu/server/generic_service.cc File src/kudu/server/generic_service.cc: http://gerrit.cloudera.org:8080/#/c/11886/3/src/kudu/server/generic_service.cc@182 PS3, Line 182: LOG(INFO) << "LeakSanitizer found false positives. Ignoring them."; Won't this print in the normal case where there are no leaks at all? Seems like you need to detect a true->false transition here (where the initial true state from L178 doesn't count) and only LOG then. -- To view, visit http://gerrit.cloudera.org:8080/11886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f199795c48bd9b6106110aae132ec165eb0f647 Gerrit-Change-Number: 11886 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 07 Nov 2018 22:54:03 +0000 Gerrit-HasComments: Yes
