Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11681 )
Change subject: Add "network_plane" as part of ConnectionId ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/11681/4/src/kudu/rpc/rpc-test.cc File src/kudu/rpc/rpc-test.cc: http://gerrit.cloudera.org:8080/#/c/11681/4/src/kudu/rpc/rpc-test.cc@696 PS4, Line 696: > Just copied and pasted that pattern from TestCredentialsPolicy. I don't see Was cleaning my inbox and found this thread. Just FYI: the decision to use mixed ASSERT and EXPECT in TestCredentialsPolicy is to spot more details if would a failure happen. Without asserting on OK return status of a function that outputs some metrics it does not make sense to look at those, however, I think it's beneficial to see all mismatches, not just the first one. That's about collecting more information on the whole picture. -- To view, visit http://gerrit.cloudera.org:8080/11681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6767e631fd9530ea54f5ed63ff4c8c179ab216b2 Gerrit-Change-Number: 11681 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Fri, 09 Nov 2018 01:05:37 +0000 Gerrit-HasComments: Yes
