Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11681 )

Change subject: Add "network_plane" as part of ConnectionId
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11681/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11681/1//COMMIT_MSG@7
PS1, Line 7: Add "network_plane" as part of ConnectionId
> Specifying it per service seems a bit rigid as it hardcodes the data plane
OK, thanks for the explanation. I think Todd's justification for per-RPC might 
hinge on the fact that, within Kudu, we generally use one proxy for every 
remote+service pair. So if the service plane is a property of the proxy, we'd 
need to establish multiple (probably just two) proxies for each remote+service 
pair.

Anyway I don't have a strong feeling about this, and judging by Todd's earlier 
suggestions, neither does he.



--
To view, visit http://gerrit.cloudera.org:8080/11681
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6767e631fd9530ea54f5ed63ff4c8c179ab216b2
Gerrit-Change-Number: 11681
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Thu, 08 Nov 2018 00:33:46 +0000
Gerrit-HasComments: Yes

Reply via email to