Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11968 )
Change subject: [webui] Fancy table for /mem-trackers and sortable tables ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js File www/kudu.js: http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@18 PS1, Line 18: // Converts a human-readable bytes value like '1.23B' or '985.32M' to a number : // of bytes. The suffix must be present: '1.23' is not valid but '1.23B' is. Seems like we could relax the suffix restriction if we parsed the last byte of the string first. If it's a letter, we parse the remaining string into a float and transform the value based on the unit (erroring if it's a letter we don't recognize). If it's a digit, we parse the entire string as a float and don't transform it. http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@41 PS1, Line 41: case 'k': val *= 1024.0; Curious why we do special treatment for lower-case k but not for any of the other units? http://gerrit.cloudera.org:8080/#/c/11968/1/www/maintenance-manager.mustache File www/maintenance-manager.mustache: http://gerrit.cloudera.org:8080/#/c/11968/1/www/maintenance-manager.mustache@66 PS1, Line 66: Ram Nit: isn't 'RAM' a more precise term though? -- To view, visit http://gerrit.cloudera.org:8080/11968 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727 Gerrit-Change-Number: 11968 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 00:21:47 +0000 Gerrit-HasComments: Yes
