Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11968 )

Change subject: [webui] Fancy table for /mem-trackers and sortable tables
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js
File www/kudu.js:

http://gerrit.cloudera.org:8080/#/c/11968/1/www/kudu.js@41
PS1, Line 41:     case 'B': break;
> Well, frankly, it's because I copied the body of the switch statement from
>From HumanReadableNumBytes::ToDouble:

  case 'Y':  d *= 1024.0;   // That's a yotta bytes!

It's not _that_ bad...



--
To view, visit http://gerrit.cloudera.org:8080/11968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf8e7bd82fe2b95e699b8bb238a9cf0e5a7e727
Gerrit-Change-Number: 11968
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mitch Barnett <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Wed, 21 Nov 2018 01:02:03 +0000
Gerrit-HasComments: Yes

Reply via email to