Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11975 )
Change subject: [tools] Add tool to dump memtrackers ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11975/1/src/kudu/util/mem_tracker.cc File src/kudu/util/mem_tracker.cc: http://gerrit.cloudera.org:8080/#/c/11975/1/src/kudu/util/mem_tracker.cc@198 PS1, Line 198: to_process.top() nit: maybe, might save a bit on copying if using std::move(to_process.top()) here? -- To view, visit http://gerrit.cloudera.org:8080/11975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e54f809bb6434b8d8e8c95771fe089c9da122d0 Gerrit-Change-Number: 11975 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 19:00:31 +0000 Gerrit-HasComments: Yes
