Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/11975 )
Change subject: [tools] Add tool to dump memtrackers ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_common.h File src/kudu/tools/tool_action_common.h: http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_common.h@136 PS3, Line 136: Status DumpMemTrackers(const std::string& address, uint16_t default_port); > Doc. Done http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_diagnose.cc File src/kudu/tools/tool_action_diagnose.cc: http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_diagnose.cc@44 PS3, Line 44: using std::array; > warning: using decl 'array' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_diagnose.cc@45 PS3, Line 45: using std::cout; > warning: using decl 'cout' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_diagnose.cc@46 PS3, Line 46: using std::endl; > warning: using decl 'endl' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_master.cc@169 PS3, Line 169: .AddOptionalParameter("format") > Did you need to override the description for this? And in tool_action_tserv No, I think the description for 'memtracker_output' covers it: "One of 'json', 'json_compact' or 'table'. Table output flattens " "the memtracker hierarchy." --format kicks in when 'table' output is chosen. http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_tserver.cc File src/kudu/tools/tool_action_tserver.cc: http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/tools/tool_action_tserver.cc@166 PS3, Line 166: tablet server > Nit: Kudu Tablet Server Done http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/util/mem_tracker-test.cc File src/kudu/util/mem_tracker-test.cc: http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/util/mem_tracker-test.cc@192 PS3, Line 192: gc000->Consume(40); : gc000->Release(20); > On second thought, I think we want to promote usage of SCOPED_CLEANUP over Done http://gerrit.cloudera.org:8080/#/c/11975/3/src/kudu/util/mem_tracker-test.cc@192 PS3, Line 192: gc000->Consume(40); : gc000->Release(20); > You can use ScopedTrackedConsumption here to avoid the SCOPED_CLEANUP below N/A -- To view, visit http://gerrit.cloudera.org:8080/11975 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e54f809bb6434b8d8e8c95771fe089c9da122d0 Gerrit-Change-Number: 11975 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mitch Barnett <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 17:45:45 +0000 Gerrit-HasComments: Yes
