Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11860 )
Change subject: (05/05) delta_applier: support for diff scan style iteration ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc File src/kudu/tablet/diskrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@756 PS5, Line 756: rowid_t uint32_t according to the schema? http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@831 PS5, Line 831: val.get_ptr()); just wondering, do you know of coverage for nullability elsewhere? http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@853 PS5, Line 853: oepration operation http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@855 PS5, Line 855: 4 3? Or should else be a no-op? http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@885 PS5, Line 885: NO_FATALS(run_test(0, 1, {})); Intuitively, I would think this would capture the insert by way of the delete UNDO, leaving us with 4 rows. I suppose the reason it doesn't is that we are manually concocting this test and therefore the UNDO DELETE was never created for those rows. Is that right? Maybe worth a comment. -- To view, visit http://gerrit.cloudera.org:8080/11860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a Gerrit-Change-Number: 11860 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 19:32:59 +0000 Gerrit-HasComments: Yes
