Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11860 )
Change subject: (05/05) delta_applier: support for diff scan style iteration ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc File src/kudu/tablet/diskrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/11860/5/src/kudu/tablet/diskrowset-test.cc@831 PS5, Line 831: val.get_ptr()); > For diff scans? I don't think so. But it'd be pretty straight-forward to ad I relented and pushed a new patch to do this: https://gerrit.cloudera.org/c/11994/ -- To view, visit http://gerrit.cloudera.org:8080/11860 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I895350a3c7728df88a87a36b904ffdea4f3f6b7a Gerrit-Change-Number: 11860 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 27 Nov 2018 05:14:07 +0000 Gerrit-HasComments: Yes
