Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract ...................................................................... Patch Set 1: > I was thinking we could create new classloader for those tests, that way we > could append appropriate jars. I put together the plumbing support for and an example of an end-to-end test at https://gerrit.cloudera.org/c/12147/ -- please take a look and let me know what you think. I took the simplest approach that I could find. That patch conflicts with this one on a couple of lines because I removed the existing OS-detection logic due to it failing the test. I thought it was better to remove it than try to fix it because you are overhauling that part of the code in this patch right now. -- To view, visit http://gerrit.cloudera.org:8080/12141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c Gerrit-Change-Number: 12141 Gerrit-PatchSet: 1 Gerrit-Owner: Brian McDevitt <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 03 Jan 2019 01:29:35 +0000 Gerrit-HasComments: No
