Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12141/3/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java File java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java: http://gerrit.cloudera.org:8080/#/c/12141/3/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java@93 PS3, Line 93: OutputStream propsOutputStream = Files.newOutputStream(propsPath); Getting this error on Jenkins: JUnit version 4.12 .17:13:58.612 [INFO - main] (TestKuduBinaryJarExtractor.java:57) Creating fake kudu binary jar at /tmp/fake-osx-kudu-binary7070665978496634390/fake-osx-kudu-binary.jar E.17:13:58.640 [INFO - main] (TestKuduBinaryJarExtractor.java:57) Creating fake kudu binary jar at /tmp/fake-osx-kudu-binary5332688690569538223/fake-osx-kudu-binary.jar E Time: 0.048 There were 2 failures: 1) testExtractJar(org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor) java.nio.file.NoSuchFileException: META-INF/ at com.sun.nio.zipfs.ZipFileSystem.checkParents(ZipFileSystem.java:863) at com.sun.nio.zipfs.ZipFileSystem.newOutputStream(ZipFileSystem.java:528) at com.sun.nio.zipfs.ZipPath.newOutputStream(ZipPath.java:790) at com.sun.nio.zipfs.ZipFileSystemProvider.newOutputStream(ZipFileSystemProvider.java:285) at java.nio.file.Files.newOutputStream(Files.java:216) at org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor.createKuduBinaryJar(TestKuduBinaryJarExtractor.java:93) at org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor.testExtractJar(TestKuduBinaryJarExtractor.java:127) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at org.junit.runner.JUnitCore.runMain(JUnitCore.java:77) at org.junit.runner.JUnitCore.main(JUnitCore.java:36) 2) testIsKuduBinaryJarOnClasspath(org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor) java.nio.file.NoSuchFileException: META-INF/ at com.sun.nio.zipfs.ZipFileSystem.checkParents(ZipFileSystem.java:863) at com.sun.nio.zipfs.ZipFileSystem.newOutputStream(ZipFileSystem.java:528) at com.sun.nio.zipfs.ZipPath.newOutputStream(ZipPath.java:790) at com.sun.nio.zipfs.ZipFileSystemProvider.newOutputStream(ZipFileSystemProvider.java:285) at java.nio.file.Files.newOutputStream(Files.java:216) at org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor.createKuduBinaryJar(TestKuduBinaryJarExtractor.java:93) at org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor.testIsKuduBinaryJarOnClasspath(TestKuduBinaryJarExtractor.java:146) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at org.junit.runner.JUnitCore.runMain(JUnitCore.java:77) at org.junit.runner.JUnitCore.main(JUnitCore.java:36) FAILURES!!! Tests run: 2, Failures: 2 http://gerrit.cloudera.org:8080/#/c/12141/3/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java@127 PS3, Line 127: "osx" For a positive test we can just use the OS detector to make it match, since we're not testing the OS detector, we're just testing our comparison logic. For a negative test we could just use some unsupported OS like "windows" or something -- To view, visit http://gerrit.cloudera.org:8080/12141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c Gerrit-Change-Number: 12141 Gerrit-PatchSet: 3 Gerrit-Owner: Brian McDevitt <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 04 Jan 2019 19:19:34 +0000 Gerrit-HasComments: Yes
