Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12134 )

Change subject: [gradle] Increase test JVMs heap size
......................................................................


Patch Set 1:

I am okay with this.

Though, I would like to understand why the memory usage for these tests are so 
high. It would be nice if we could make the test more efficient in place of 
raising the limit for all tests.

Just looking at the code, I suspect it could be the use of the 
CapturingLogAppender. It captures all logged events of any level in a 
StringBuilder. Perhaps adding a filter so that only events above a certain 
level are captured would solve the problem and make the test more 
efficient/accurate.


--
To view, visit http://gerrit.cloudera.org:8080/12134
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d
Gerrit-Change-Number: 12134
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Jan 2019 01:48:23 +0000
Gerrit-HasComments: No

Reply via email to