Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12134 )
Change subject: [gradle] Increase test JVMs heap size ...................................................................... Patch Set 1: > I am okay with this. > > Though, I would like to understand why the memory usage for these > tests are so high. It would be nice if we could make the test more > efficient in place of raising the limit for all tests. > > Just looking at the code, I suspect it could be the use of the > CapturingLogAppender. It captures all logged events of any level in > a StringBuilder. Perhaps adding a filter so that only events above > a certain level are captured would solve the problem and make the > test more efficient/accurate. I agree we should figure out the root cause of high memory usage. Although, I think we can have this patch first to de-flake the test (I noticed this test has become flaky after we switched to Gradle in some environment which has set the maximum java heap size to 1g for Maven). And do a follow up for improve the memory usage. -- To view, visit http://gerrit.cloudera.org:8080/12134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae86fe493a1fdc337d5ca8615b043b437a2a116d Gerrit-Change-Number: 12134 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 29 Jan 2019 00:36:03 +0000 Gerrit-HasComments: No
