Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 )
Change subject: KUDU-2543 pt 1: basic checks for authz tokens ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/11751/8/src/kudu/rpc/rpc_verification_util.h File src/kudu/rpc/rpc_verification_util.h: http://gerrit.cloudera.org:8080/#/c/11751/8/src/kudu/rpc/rpc_verification_util.h@34 PS8, Line 34: // 'retry_error' is the error code used to denote whether verification should : // be retried. To me this looks more like a type of token that's being verified. Maybe, instead combine the code from VerifyAuthzTokenOrRespond() and the part of ServerNegotiation::AuthenticateByToken() that performs token verification and differentiate the code by the type of token used? http://gerrit.cloudera.org:8080/#/c/11751/8/src/kudu/rpc/rpc_verification_util.cc File src/kudu/rpc/rpc_verification_util.cc: http://gerrit.cloudera.org:8080/#/c/11751/8/src/kudu/rpc/rpc_verification_util.cc@36 PS8, Line 36: security nit for here and below: if that 'using security::VerificationResult' is present, why to specify the namespace here? -- To view, visit http://gerrit.cloudera.org:8080/11751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99555e0ab2d09d4abcbc12b1100658a9a17590f4 Gerrit-Change-Number: 11751 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 03 Jan 2019 06:53:18 +0000 Gerrit-HasComments: Yes
