Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/11751 )
Change subject: KUDU-2543 pt 1: basic checks for authz tokens ...................................................................... Patch Set 10: (3 comments) LGTM, just minor nits. http://gerrit.cloudera.org:8080/#/c/11751/10/src/kudu/tserver/tablet_server_authorization-test.cc File src/kudu/tserver/tablet_server_authorization-test.cc: http://gerrit.cloudera.org:8080/#/c/11751/10/src/kudu/tserver/tablet_server_authorization-test.cc@182 PS10, Line 182: 3600 nit: can you add a comment on why this number is used? http://gerrit.cloudera.org:8080/#/c/11751/10/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/11751/10/src/kudu/tserver/tablet_service.cc@152 PS10, Line 152: tserver_inject_invalid_authz_token_ratio Can you add a comment on when this is expected to be used? http://gerrit.cloudera.org:8080/#/c/11751/9/src/kudu/tserver/tserver_service.proto File src/kudu/tserver/tserver_service.proto: http://gerrit.cloudera.org:8080/#/c/11751/9/src/kudu/tserver/tserver_service.proto@100 PS9, Line 100: : : > Done; good catch, this doesn't belong at all. It's a part of the ChecksumRe Can you add a comment in ChecksumRequestPB that the authz token is embedded in NewScanRequestPB to be more clear? -- To view, visit http://gerrit.cloudera.org:8080/11751 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I99555e0ab2d09d4abcbc12b1100658a9a17590f4 Gerrit-Change-Number: 11751 Gerrit-PatchSet: 10 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 08 Jan 2019 00:55:07 +0000 Gerrit-HasComments: Yes
