Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 )
Change subject: [fs]: wrapping up containers in scoped_refptr ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12121/3/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/12121/3/src/kudu/fs/log_block_manager.cc@233 PS3, Line 233: LogBlockContainerRefPtr container_; > The durations of 'dense_node-itest' before and after this change show littl Yes, that would be great. You can generate flame graphs of the node starting up using the tools at https://github.com/brendangregg/FlameGraph (the README is informative), then compare before/after. http://gerrit.cloudera.org:8080/#/c/12121/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/12121/4/src/kudu/fs/log_block_manager.cc@1274 PS4, Line 1274: Unretained(container), Don't we need to refcount 'container' here, so that we guarantee that its last ref isn't dropped when deleted_interval_map_ goes out of scope? Or will that be in the follow-on patch that implements container deletion? -- To view, visit http://gerrit.cloudera.org:8080/12121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c5c620014782b3d57dcbe047d0df73c949590c7 Gerrit-Change-Number: 12121 Gerrit-PatchSet: 4 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Fri, 04 Jan 2019 20:36:17 +0000 Gerrit-HasComments: Yes
