helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12121 )
Change subject: [fs]: wrapping up containers in scoped_refptr ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12121/4/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/12121/4/src/kudu/fs/log_block_manager.cc@1274 PS4, Line 1274: Unretained(container), > Yeah but isn't that only if 'container' is NOT passed via Unretained()? Tha Hrm, it's correct to drop the Unretained() wrapper. To ContainerDeletionAsync, it seems that it's not necessary to accept a scoped_refptr<LogBlockContainer> according to https://github.com/apache/kudu/blob/678dbac6fb05d0370e40e6645d4b1ec530fa0180/src/kudu/gutil/callback.h#L120 and https://github.com/apache/kudu/blob/678dbac6fb05d0370e40e6645d4b1ec530fa0180/src/kudu/gutil/bind.h#L209. -- To view, visit http://gerrit.cloudera.org:8080/12121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c5c620014782b3d57dcbe047d0df73c949590c7 Gerrit-Change-Number: 12121 Gerrit-PatchSet: 4 Gerrit-Owner: helifu <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: helifu <[email protected]> Gerrit-Comment-Date: Mon, 07 Jan 2019 12:25:49 +0000 Gerrit-HasComments: Yes
