Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12162 )
Change subject: Support CXXFLAGS ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12162/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12162/1//COMMIT_MSG@13 PS1, Line 13: I'm doing this to make it easier to stage a GCC : upgrade in Impala. I'm curious about this: are you using _GLIBCXX_USE_CXX11_ABI=0 temporarily, and reverting it when the upgrade is done? If you control the entire toolchain you should able to use the new gcc5 ABI safely. http://gerrit.cloudera.org:8080/#/c/12162/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12162/1/CMakeLists.txt@125 PS1, Line 125: # Start with flags from the standard CXXFLAGS environment variable. : # Additional flags are appended after $CXXFLAGS, so that the Kudu build : # overrides any generic flags. : set(CXX_COMMON_FLAGS "$ENV{CXXFLAGS}") What if we changed L215-L229 such that CMAKE_CXX_FLAGS is no longer clobbered, but is instead appended to? IIUC cmake will automatically initialize CMAKE_CXX_FLAGS with the value of ENV{CXXFLAGS}, so as long as we don't clobber it, we'll get that behavior you want for free and we won't need to get indirectly via CXX_COMMON_FLAGS. -- To view, visit http://gerrit.cloudera.org:8080/12162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9dcad5ccb4fc4c081d96eaa40957175731c7a9e Gerrit-Change-Number: 12162 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 04 Jan 2019 22:21:11 +0000 Gerrit-HasComments: Yes
