Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12162 )
Change subject: Support CXXFLAGS ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12162/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12162/1/CMakeLists.txt@125 PS1, Line 125: # Start with flags from the standard CXXFLAGS environment variable. : # Additional flags are appended after $CXXFLAGS, so that the Kudu build : # overrides any generic flags. : set(CXX_COMMON_FLAGS "$ENV{CXXFLAGS}") > The order of the flags does matter, and we should probably make sure the us Yeah I think I'll skip doing that if that's ok. http://gerrit.cloudera.org:8080/#/c/12162/2/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12162/2/CMakeLists.txt@210 PS2, Line 210: # release type names and this provides compatibility with the CLion IDE. > Could you add a comment here noting that it's important not to clobber CMAK Done -- To view, visit http://gerrit.cloudera.org:8080/12162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9dcad5ccb4fc4c081d96eaa40957175731c7a9e Gerrit-Change-Number: 12162 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 07 Jan 2019 17:47:02 +0000 Gerrit-HasComments: Yes
