Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12194 )
Change subject: Eliminate redundant VLOG_IS_ON calls ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12194/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12194/1//COMMIT_MSG@13 PS1, Line 13: The expression on the righthand side of the << operator is evaluated : only when VLOG_IS_ON(3) is true. Intuitively this makes sense, but what proves that it's true? http://gerrit.cloudera.org:8080/#/c/12194/1/src/kudu/consensus/consensus_queue.cc File src/kudu/consensus/consensus_queue.cc: http://gerrit.cloudera.org:8080/#/c/12194/1/src/kudu/consensus/consensus_queue.cc@872 PS1, Line 872: for (const auto& watermark : watermarks) { I think "auto watermark" is probably better; I vaguely remember Todd mentioning something in the past about the cost of loading through a reference vs. copying a primitive value. -- To view, visit http://gerrit.cloudera.org:8080/12194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0781e64f95e33fe067f9f3e65e77aec8654f4ba3 Gerrit-Change-Number: 12194 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 09:42:29 +0000 Gerrit-HasComments: Yes
