Hello Mike Percy, Alexey Serbin, Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12194 to look at the new patch set (#3). Change subject: Eliminate redundant VLOG_IS_ON calls ...................................................................... Eliminate redundant VLOG_IS_ON calls In an expression like VLOG(3) << Substitute("Your $0 is $1", expensive_foo(), costly_bar()); The expression on the righthand side of the << operator is evaluated only when VLOG_IS_ON(3) is true. However, there were some cases of defensive programming like if (VLOG_IS_ON(3)) { VLOG(3) << Substitute("Your $0 is $1", expensive_foo(), costly_bar()); } with a redundant call to VLOG_IS_ON. This patch removes such cases as I found from a simple review of all VLOG_IS_ON callsites. I also sometimes transformed VLOG messages from a chain of <<'s to calls to Substitute. This patch contains no functional changes. Change-Id: I0781e64f95e33fe067f9f3e65e77aec8654f4ba3 --- M src/kudu/client/batcher.cc M src/kudu/clock/hybrid_clock.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/raft_consensus.cc M src/kudu/tablet/tablet-test-base.h M src/kudu/tablet/tablet-test-util.h M src/kudu/tablet/tablet_bootstrap.cc M src/kudu/tablet/tablet_history_gc-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/util/logging-test.cc 11 files changed, 74 insertions(+), 61 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/12194/3 -- To view, visit http://gerrit.cloudera.org:8080/12194 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I0781e64f95e33fe067f9f3e65e77aec8654f4ba3 Gerrit-Change-Number: 12194 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>