Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 )
Change subject: Assign locations to tablet servers and the client in Java ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12174/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12174/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@331 PS5, Line 331: String location = ""; It looks like tests only need read only access for this. It could also be a useful API for users to be able to get their assigned location. Could this be marked private and a public getter method added? Similar to other getters this could be exposed, as passthrough, to the KuduClient too. -- To view, visit http://gerrit.cloudera.org:8080/12174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e2c74ab12f7da187bf6e75d42a3089bc20235db Gerrit-Change-Number: 12174 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 16:11:11 +0000 Gerrit-HasComments: Yes
