Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12174 )
Change subject: Assign locations to tablet servers and the client in Java ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/12174/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12174/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@331 PS5, Line 331: > It looks like tests only need read only access for this. It could also be a I did not expose the location to users because I did not want to constrain its type to being a string. In the future it might be better to structure it differently. That said, it'd be fine to have a GetLocationString() method. http://gerrit.cloudera.org:8080/#/c/12174/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/12174/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java@624 PS5, Line 624: * Adds one location to the minicluster configuration, consisting of a > Nit: "Adds" to maintain the same tense. Done -- To view, visit http://gerrit.cloudera.org:8080/12174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e2c74ab12f7da187bf6e75d42a3089bc20235db Gerrit-Change-Number: 12174 Gerrit-PatchSet: 6 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 19:35:31 +0000 Gerrit-HasComments: Yes
