Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 )
Change subject: Support location awareness in READ_CLOSEST for the Java client ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/12175/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12175/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@520 PS2, Line 520: * then do not close the synchronous client. > Done I see this message might be related to my review on the other patch. Even though the method doesn't need to be synchronized having a getter instead of a public accessible and mutable variable is still a better api practice. http://gerrit.cloudera.org:8080/#/c/12175/4/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: http://gerrit.cloudera.org:8080/#/c/12175/4/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@186 PS4, Line 186: // TODO(KUDU-2348) this doesn't return a random server, but rather returns Thanks for revamping this message. http://gerrit.cloudera.org:8080/#/c/12175/4/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java File java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java: http://gerrit.cloudera.org:8080/#/c/12175/4/java/kudu-client/src/main/java/org/apache/kudu/client/ServerInfo.java@105 PS4, Line 105: * Returns if the server is in the same location as 'location'. nit: "Returns true if ..." -- To view, visit http://gerrit.cloudera.org:8080/12175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief0f07058cefd0037f4b0f7c60c8b7809dc8313f Gerrit-Change-Number: 12175 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 16:16:00 +0000 Gerrit-HasComments: Yes
