Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12175 )
Change subject: Support location awareness in READ_CLOSEST for the Java client ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12175/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12175/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@518 PS5, Line 518: * Nit: got some trailing whitespace here. http://gerrit.cloudera.org:8080/#/c/12175/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@521 PS5, Line 521: public String getLocationString() { Not to bike-shed, but why not just 'getLocation'? Isn't that the typical name for an accessor in Java? -- To view, visit http://gerrit.cloudera.org:8080/12175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ief0f07058cefd0037f4b0f7c60c8b7809dc8313f Gerrit-Change-Number: 12175 Gerrit-PatchSet: 5 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 19:40:27 +0000 Gerrit-HasComments: Yes
