Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12156 )
Change subject: generic_iterators: assorted cleanup ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/common/generic_iterators.cc@247 PS3, Line 247: if (!s->schema().Equals(*schema_)) { > is this going to be expensive in release builds? should we consider only do I'd be on board with making this a DCHECK. http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/common/generic_iterators.cc@472 PS3, Line 472: s.append("Union("); > while we're here, perhaps we can clean up this function to do: I'd be inclined to do this in a follow up because I am modifying this same file and conflicting all over the place with this patch series so would like to maintain velocity and granularity for these changes. -- To view, visit http://gerrit.cloudera.org:8080/12156 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1fd5f4cd1a8ef621d3ac994e764dfd19e99544 Gerrit-Change-Number: 12156 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 22:18:26 +0000 Gerrit-HasComments: Yes
