Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12156 )
Change subject: generic_iterators: assorted cleanup ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/common/generic_iterators.h File src/kudu/common/generic_iterators.h: http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/common/generic_iterators.h@58 PS3, Line 58: // All iterators must be fully able to evaluate all predicates (i.e. calling : // iter->Init(spec) should remove all predicates from the ScanSpec). is this true? i thought the fact that we use InitAndMaybeWrap means that we handle the necessary wrapping internal to this class if the caller passes in one that doesn't handle predicates http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/common/generic_iterators.cc@247 PS3, Line 247: if (!s->schema().Equals(*schema_)) { is this going to be expensive in release builds? should we consider only doing it in debug? or should we wait until proven to be a hotspot before optimizing it out? http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/common/generic_iterators.cc@249 PS3, Line 249: string("Schemas do not match: ") + schema_->ToString() : + " vs " + s->schema().ToString()); this is somewhat non-idiomatic (why not use Substitute?) http://gerrit.cloudera.org:8080/#/c/12156/3/src/kudu/common/generic_iterators.cc@472 PS3, Line 472: s.append("Union("); while we're here, perhaps we can clean up this function to do: s += JoinMapped(iters_, [](const shared_ptr<RowwiseIterator>& it) { return it->ToString(); }); (too bad we don't have C++14 for lambda auto arguments) -- To view, visit http://gerrit.cloudera.org:8080/12156 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1fd5f4cd1a8ef621d3ac994e764dfd19e99544 Gerrit-Change-Number: 12156 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 18:15:48 +0000 Gerrit-HasComments: Yes
