Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12157 )
Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12157/6/src/kudu/common/generic_iterators-test.cc File src/kudu/common/generic_iterators-test.cc: http://gerrit.cloudera.org:8080/#/c/12157/6/src/kudu/common/generic_iterators-test.cc@217 PS6, Line 217: bool row_selected = prng.Uniform(8) > 0; Would you mind adding a comment about this? I'm confused about what is being tested and how, particularly why it's OK to randomly deselect rows in these tests given a predicate. -- To view, visit http://gerrit.cloudera.org:8080/12157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I529e632f40943962d34c184b29b5cff7604ad59b Gerrit-Change-Number: 12157 Gerrit-PatchSet: 6 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 22:29:42 +0000 Gerrit-HasComments: Yes
