Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12157 )
Change subject: generic_iterators: short-circuit MergeIterState::PullNextBlock ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/12157/4/src/kudu/common/generic_iterators-test.cc File src/kudu/common/generic_iterators-test.cc: http://gerrit.cloudera.org:8080/#/c/12157/4/src/kudu/common/generic_iterators-test.cc@235 PS4, Line 235: all_ints.emplace_back(std::move(l)); would this work just using emplace_back(std::move(ints), std::move(sv))? or maybe similar but with a {} in there? http://gerrit.cloudera.org:8080/#/c/12157/4/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/12157/4/src/kudu/common/generic_iterators.cc@199 PS4, Line 199: // Seek next_row_ to the first selected row. maybe this isn't a bottleneck, but mind adding a TODO to use BitmapFindFirst here? http://gerrit.cloudera.org:8080/#/c/12157/4/src/kudu/common/generic_iterators.cc@207 PS4, Line 207: LOG(DFATAL) << "Unreachable code"; // guaranteed by the short-circuit above wonder whether this should be a real FATAL - note that DFATAL still emits error log messages in release builds -- To view, visit http://gerrit.cloudera.org:8080/12157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I529e632f40943962d34c184b29b5cff7604ad59b Gerrit-Change-Number: 12157 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 18:21:49 +0000 Gerrit-HasComments: Yes
